feat: remove optional fields when unnecessary #216
Conversation
…veOptionalFieldsWhenUnnecessary
|
Lemme know when I should review this. I could see splitting it into smaller PRs, but only if that's easier for you. |
src/lib/decode-conversions.ts
Outdated
| @@ -95,7 +95,8 @@ export const convertObservation: ConvertFunction<'observation'> = ( | |||
| ...rest, | |||
| attachments: message.attachments.map(convertAttachment), | |||
| tags: convertTags(message.tags), | |||
| metadata: message.metadata || {}, | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
Once I solve this type error, which I'm not being able for the time being, I think this is mostly ready to merge
EvanHahn
changed the title
| @@ -95,7 +95,7 @@ export const convertObservation: ConvertFunction<'observation'> = ( | |||
| ...rest, | |||
| attachments: message.attachments.map(convertAttachment), | |||
| tags: convertTags(message.tags), | |||
| metadata: message.metadata || {}, | |||
There was a problem hiding this comment.
If we set up a default value for metadata it should be smth like {manualLocation:true}, since manualLocation now is required. That field will default to false if undefined, so if we're okay with that, maybe we could leave it undefined?
There was a problem hiding this comment.
As long as we don't accidentally get manualLocation: undefined when reading, I'm fine with whatever.
There was a problem hiding this comment.
According to this at least, we should be fine
|
Just seeing this now following the issues with the front end. I think there are one or two things we need to review here. I can take a look Monday morning. @EvanHahn @tomasciccola |
should close #200